fix: DefaultDocumentValidationService의 경로 탐색(Path Traversal) 및 NPE 버그 수정 - #237
fix: DefaultDocumentValidationService의 경로 탐색(Path Traversal) 및 NPE 버그 수정#237seonghobae wants to merge 1 commit into
Conversation
`DefaultDocumentValidationService`에서 `Path.of`를 사용할 때 발생할 수 있는 잠재적인 경로 조작 취약점을 `StringUtils.cleanPath`를 사용하도록 변경하여 수정했습니다. 또한 `tokenFingerprint` 메서드에서 인자가 `null`일 때 발생할 수 있는 `NullPointerException`을 방지하기 위한 널 체크 로직을 추가했습니다. 관련된 테스트 케이스와 CHANGELOG 항목도 업데이트되었습니다.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
1 participant
Closed to avoid a conflicting security stack. The token-fingerprint null handling is superseded by #165, which renames and generalizes the fingerprint function. The cross-platform filename normalization should be reintroduced as a focused PR after #165 merges, with Windows backslash, UNC, drive-letter, encoded-separator, and trailing-separator tests.